lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hrishikesh Gadre (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-7637) Improve error logging in the zkcli CLUSTERPROP command
Date Thu, 25 Jun 2015 21:57:05 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602025#comment-14602025
] 

Hrishikesh Gadre edited comment on SOLR-7637 at 6/25/15 9:56 PM:
-----------------------------------------------------------------

>>It is today – there's no guarantee that it will be in the future. I realize the
first exception today is pretty useless. What about getting the root cause, e.g. http://commons.apache.org/proper/commons-lang/javadocs/api-3.1/org/apache/commons/lang3/exception/ExceptionUtils.html#getRootCause(java.lang.Throwable)
? Or providing an example where that is not the correct thing to do.

I personally don't see a lot of value of going below Zookeeper exception object especially
since it has error code associated with it. But if you think that is important, we can simply
print the exception trace so that all the stack trace will be available for debugging.

>>I think this is a reasonable argument, but seems most appropriate for a different
jira. If you are motivated, feel free to open another jira to discussing moving the errors
from System.out to System.err.

Ok that is fine.


was (Author: hgadre):
>>It is today – there's no guarantee that it will be in the future. I realize the
first exception today is pretty useless. What about getting the root cause, e.g. http://commons.apache.org/proper/commons-lang/javadocs/api-3.1/org/apache/commons/lang3/exception/ExceptionUtils.html#getRootCause(java.lang.Throwable)
? Or providing an example where that is not the correct thing to do.

I personally don't see a lot of value of going below Zookeeper exception object especially
since it as error codes associated with it. But if you think that is important, we can simply
print the exception trace so that all the stack trace will be available for debugging.

>>I think this is a reasonable argument, but seems most appropriate for a different
jira. If you are motivated, feel free to open another jira to discussing moving the errors
from System.out to System.err.

Ok that is fine.

> Improve error logging in the zkcli CLUSTERPROP command
> ------------------------------------------------------
>
>                 Key: SOLR-7637
>                 URL: https://issues.apache.org/jira/browse/SOLR-7637
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hrishikesh Gadre
>            Assignee: Gregory Chanan
>            Priority: Trivial
>         Attachments: SOLR-7637.patch
>
>
> SOLR-7176 introduced capability to update Solr cluster properties via ZK CLI. The error
logging implemented as part of that fix was not proper (i.e. the actual error was getting
masked). We should improve the error logging to explicitly state the root cause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message