lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hrishikesh Gadre (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-7637) Improve error logging in the zkcli CLUSTERPROP command
Date Fri, 26 Jun 2015 00:20:05 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602171#comment-14602171
] 

Hrishikesh Gadre commented on SOLR-7637:
----------------------------------------

>>What's an example of "going below Zookeeper exception object?" Can you give me a before
vs after? I'm not sure a backtrace is ideal for a CLI command, that sounds like something
that should go in a log (though I don't think there is any log set up for the zkcli).

Never mind. I found that the way KeeperException is constructed, it can not contain a different
exception object as a root-cause. So we are guaranteed to get KeeperException even if we use
ExceptionUtils.getRootCause(...)
https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/KeeperException.java


> Improve error logging in the zkcli CLUSTERPROP command
> ------------------------------------------------------
>
>                 Key: SOLR-7637
>                 URL: https://issues.apache.org/jira/browse/SOLR-7637
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hrishikesh Gadre
>            Assignee: Gregory Chanan
>            Priority: Trivial
>         Attachments: SOLR-7637.patch
>
>
> SOLR-7176 introduced capability to update Solr cluster properties via ZK CLI. The error
logging implemented as part of that fix was not proper (i.e. the actual error was getting
masked). We should improve the error logging to explicitly state the root cause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message