lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-6547) Add dateline crossing support to GeoPointInBBox and GeoPointDistance Queries
Date Sat, 27 Jun 2015 22:06:04 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-6547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael McCandless updated LUCENE-6547:
---------------------------------------
    Attachment: LUCENE-6547.patch

Here's a new patch, starting from [~nknize]'s last patch, and trying to
make the verify method more approachable (I really don't want this to
turn into another TestGrouping.testRandom!)

In doing this I think I found a couple test bugs:

  * The polygon query test was supposed to only pass the "too big"
    bbox as the bbox args, and the "original" bbox as the polygon

  * tolerateRadiusErrors should not need lat1/lon1?  It should only
    need a single point, not two points?  How can these
    randomly generated values matter? (The query doesn't get them).
    I left a nocommit in this patch about that ...

Can we remove the separate bbox from GeoPointInPolygonQuery's ctor?
This seems very trappy (what if you pass the wrong bbox?), and any
perf gains should be negligible in the limit (of bigger and bigger
indices)?


> Add dateline crossing support to GeoPointInBBox and GeoPointDistance Queries
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-6547
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6547
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Nicholas Knize
>         Attachments: LUCENE-6547.patch, LUCENE-6547.patch, LUCENE-6547.patch, LUCENE-6547.patch,
LUCENE-6547.patch, LUCENE-6547.patch, LUCENE-6547.patch
>
>
> The current GeoPointInBBoxQuery only supports bounding boxes that are within the standard
-180:180 longitudinal bounds. While its perfectly fine to require users to split dateline
crossing bounding boxes in two, GeoPointDistanceQuery should support distance queries that
cross the dateline.  Since morton encoding doesn't support unwinding this issue will add dateline
crossing to GeoPointInBBoxQuery and GeoPointDistanceQuery classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message