lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6562) GeoPointInBBoxQuery should compute ranges once, not per-segment
Date Mon, 29 Jun 2015 19:42:05 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606237#comment-14606237
] 

Michael McCandless commented on LUCENE-6562:
--------------------------------------------

[~thetaphi] I think you suggested (in person, over beers!) that there there a cleaner way
to do this?  I forgot what you said, maybe too many beers.

In this patch I made a custom rewrite method for these geo queries, which holds onto the ranges
and shares across segments ...

The ranges can become huge when the bbox is accidentally adversarial, so it'd be best to not
regenerate per segment.

I think we may want to set a limit on the queries too, much like how regexp queries limit
the max determined states by default.

> GeoPointInBBoxQuery should compute ranges once, not per-segment
> ---------------------------------------------------------------
>
>                 Key: LUCENE-6562
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6562
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 5.3, Trunk
>
>         Attachments: LUCENE-6562.patch, LUCENE-6562.patch
>
>
> We tried to do this in the original issue, using the same shard attributes that FuzzyQuery
did, but it's not quite working...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message