lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6564) Normalize date format for IW in unit tests
Date Mon, 15 Jun 2015 18:18:02 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586431#comment-14586431
] 

Uwe Schindler commented on LUCENE-6564:
---------------------------------------

bq. I would love to calculate the developer time / cost ratio of this ticket  Gotta love Open
Source.

LOL. Yes, oh yes! :-) But we also fixed a bug. Because the SImpleDateFormat used in the PrintStreamInfoStream
was not thread safe at all! So we also fixed a bug. Thanks to Robert for pointing this out
(unfortunately ForbiddenApis cannot detect multithreaded use of SimpleDateFormat....)

bq. But can you add a comment explaining why we abuse the FileTime API?

Will do. I am out of office, will prepare this later.

> Normalize date format for IW in unit tests
> ------------------------------------------
>
>                 Key: LUCENE-6564
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6564
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Ramkumar Aiyengar
>            Assignee: Ramkumar Aiyengar
>            Priority: Minor
>             Fix For: 5.3
>
>         Attachments: LUCENE-6564.patch, LUCENE-6564.patch, LUCENE-6564.patch
>
>
> Noticed while debugging some IW output in an unit test that milliseconds were not output
in the date, changed this to reuse the date format used by {{PrintStreamInfoStream}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message