lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6588) ToChildBlockJoinQuery does not calculate parent score if the first child is not in acceptDocs
Date Fri, 19 Jun 2015 12:12:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593370#comment-14593370
] 

ASF GitHub Bot commented on LUCENE-6588:
----------------------------------------

GitHub user ChristophKaser opened a pull request:

    https://github.com/apache/lucene-solr/pull/155

    To child block join query fixes

    Pull request for LUCENE-6588

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ChristophKaser/lucene-solr ToChildBlockJoinQueryFixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #155
    
----
commit 1242d581519cb01e12a8f32eec89bfdccecad1d8
Author: ChristophKaser <berlin@caser.de>
Date:   2015-06-19T11:42:54Z

    Test score calculation
    
    test whether all hits have scores when there are some deleted child
    documents (LUCENE-6588)

commit eb9fc9243df085b4324e9f71e3f6d69059924be7
Author: ChristophKaser <berlin@caser.de>
Date:   2015-06-19T11:53:22Z

    ToChildBlockJoinQuery score calculation bugfix
    
    Don't skip score calculation if first child is not in acceptDocs.

commit 45ed3c5674a9b6c42ad6669dc57a98eee86e000a
Author: ChristophKaser <berlin@caser.de>
Date:   2015-06-19T12:03:34Z

    implements ToChildBlockJoinQuery.explain()

----


> ToChildBlockJoinQuery does not calculate parent score if the first child is not in acceptDocs
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-6588
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6588
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/join
>    Affects Versions: 5.2.1
>            Reporter: Christoph Kaser
>         Attachments: 0001-Test-score-calculation.patch, 0002-ToChildBlockJoinQuery-score-calculation-bugfix.patch,
0003-implements-ToChildBlockJoinQuery.explain.patch
>
>
> There is a bug in ToChildBlockJoinQuery that causes the score calculation to be skipped
if the first child of a new parent doc is not in acceptDocs.
> I will attach test showing the failure and a patch to fix it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message