lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl (JIRA) <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-7727) bin/solr script incorrectly requires solr.xml in $SOLR_HOME
Date Mon, 29 Jun 2015 21:13:05 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604918#comment-14604918
] 

Jan Høydahl edited comment on SOLR-7727 at 6/29/15 9:12 PM:
------------------------------------------------------------

Thinking more about this, an alternative solution is to change {{SolrDispatchFilter}} to look
for {{solr.xml}} in ZK by default in cloud mode, and fallback to {{SOLR_HOME}} for back compat,
getting rid of {{-Dsolr.solrxml.location}}. Do you see any problems with such a solution?
[~erickerickson] why was an explicit system-prop chosen in SOLR-4718? I'm probably not considering
the full complexity of the logic here..

Aside: Currently, if you start Solr in non-cloud mode with solrxml.location specified, e.g.
{{bin/solr start -Dsolr.solrxml.location=zookeeper}}, Jetty starts up but in a bad state,
instead of failing fast, but no error is given in the start script. Trying to access Solr
gives 500 error with nullpointer. This would also be fixed with the code-change above, since
loading solr.xml from ZK would only be attempted when in ZK mode. 


was (Author: janhoy):
Thinking more about this, an alternative solution is to change {{SolrDispatchFilter}} to look
for {{solr.xml}} in ZK by default in cloud mode, and fallback to {{SOLR_HOME}} for back compat,
getting rid of {{-Dsolr.solrxml.location}}. Do you see any problems with such a solution?

Aside: Currently, if you start Solr in non-cloud mode with solrxml.location specified, e.g.
{{bin/solr start -Dsolr.solrxml.location=zookeeper}}, Jetty starts up but in a bad state,
instead of failing fast, but no error is given in the start script. Trying to access Solr
gives 500 error with nullpointer. This would also be fixed with the code-change above, since
loading solr.xml from ZK would only be attempted when in ZK mode.

> bin/solr script incorrectly requires solr.xml in $SOLR_HOME
> -----------------------------------------------------------
>
>                 Key: SOLR-7727
>                 URL: https://issues.apache.org/jira/browse/SOLR-7727
>             Project: Solr
>          Issue Type: Bug
>          Components: scripts and tools
>    Affects Versions: 5.2.1
>            Reporter: Crawdaddy
>            Assignee: Jan Høydahl
>             Fix For: 5.3, Trunk
>
>         Attachments: SOLR-7727.patch
>
>
> The bin/solr script currently requires solr.xml to exist in $SOLR_HOME, going against
SOLR-4718 which allows it to be hosted in Zookeeper.
> Line 1219:
> if [ ! -e "$SOLR_HOME/solr.xml" ]; then
>   echo -e "\nSolr home directory $SOLR_HOME must contain a solr.xml file!\n"
>   exit 1
> fi
> Commenting this out, and specifying the following in one's solr.in.sh, allows solr.xml
to once again be hosted in ZK:
> SOLR_OPTS="$SOLR_OPTS -Dsolr.solrxml.location=zookeeper"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message