lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Benedetti (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-6641) Idea CodeSyle should be enriched
Date Tue, 30 Jun 2015 09:22:04 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14607971#comment-14607971
] 

Alessandro Benedetti edited comment on LUCENE-6641 at 6/30/15 9:21 AM:
-----------------------------------------------------------------------

I found the Eclipse CodeStyle.
Apparently spacing related it wants :

- private int test(int a,int b) -> no spaces in the declaration
- "expanded".equals(n) -> no spaces in invocation

And I find a lot of cases that satisfy this scenario.
Actually that seems the standard.
If we agree that, probably the reason it was not in the codeStyle.xml is that Intellij Idea
put it by default !

My assumption that something was wrong is because the class in SolrJ I have been working with
is not following the standard, hence my confusion :)


was (Author: alessandro.benedetti):
I found the Eclipse CodeStyle.
Apparently spacing related ti wants :

- private int test(int a,int b) -> no spaces in the declaration
- "expanded".equals(n) -> no spaces in invocation

And I find a lot of cases that satisfy this scenario.
If we agree that, probably the reason it was not in the codeStyle.xml is that Intellij Idea
put it by default !

> Idea CodeSyle should be enriched
> --------------------------------
>
>                 Key: LUCENE-6641
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6641
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: -tools
>    Affects Versions: 5.2.1
>            Reporter: Alessandro Benedetti
>              Labels: codestyle
>         Attachments: Eclipse-Lucene-Codestyle.xml
>
>
> Currently Idea CodeStyle has been fixed for latest intelljIdea version but it is not
complete.
> For example it does not contain spaces management ( space within method params, space
between operators ext )for the Java language ( and maybe for the other languages involved
as well ) .
> We should define a complete standard ( as some inconsistencies are in the committed code
as well) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message