lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6641) Idea CodeSyle should be enriched
Date Tue, 30 Jun 2015 09:49:04 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608044#comment-14608044
] 

Michael McCandless commented on LUCENE-6641:
--------------------------------------------

bq. My assumption that something was wrong is because the class in SolrJ I have been working
with is not following the standard, hence my confusion

What's vital is that we *do* have a standard.

It's much less important that we perfectly *enforce* it 100% of the time :)

It's just like in the U.S., how we have laws created over time by our legislative branch,
but then separately "enforced" by the judicial branch and sometimes scary police forces. 
So in Lucene we have a strong legislative branch but a weak police force.

Still, this way, if ever there is a disagreement on code styling, we can immediately fall
back on our "law" to quickly resolve it.  If we were law-less, we would (trust me, I've seen
it!) have awesomely huge disagreements over where a space or a { goes (https://en.wikipedia.org/wiki/Parkinson's_law_of_triviality)
and never actually make progress building search engines.

So, yes, much of our code currently "violates" the law, but that's relatively minor problem

> Idea CodeSyle should be enriched
> --------------------------------
>
>                 Key: LUCENE-6641
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6641
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: -tools
>    Affects Versions: 5.2.1
>            Reporter: Alessandro Benedetti
>              Labels: codestyle
>         Attachments: Eclipse-Lucene-Codestyle.xml
>
>
> Currently Idea CodeStyle has been fixed for latest intelljIdea version but it is not
complete.
> For example it does not contain spaces management ( space within method params, space
between operators ext )for the Java language ( and maybe for the other languages involved
as well ) .
> We should define a complete standard ( as some inconsistencies are in the committed code
as well) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message