lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Created] (SOLR-7741) SolrIndexerConfig.toMap missing fields
Date Tue, 30 Jun 2015 21:16:05 GMT
Mike Drob created SOLR-7741:
-------------------------------

             Summary: SolrIndexerConfig.toMap missing fields
                 Key: SOLR-7741
                 URL: https://issues.apache.org/jira/browse/SOLR-7741
             Project: Solr
          Issue Type: Bug
    Affects Versions: Trunk
            Reporter: Mike Drob
             Fix For: Trunk


>From the mailing list:

Mike Drob wrote:
{quote}
I was looking through code for unrelated reasons and this line stuck out to me:

https://github.com/apache/lucene-solr/blob/trunk/solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java#L180

if(mergeSchedulerInfo != null) m.put("mergeScheduler",mergeSchedulerInfo.toMap()); if(mergePolicyInfo
!= null) m.put("mergeScheduler",mergePolicyInfo.toMap());

Are they both supposed to be using the "mergeScheduler" key? If not, happy to open a JIRA
and provide the one-line patch.
{quote}

Christine Poerschke wrote:
{quote}
Follow-on question, also re: SolrIndexConfig's toMap method. The constructor reads "/mergedSegmentWarmer"
and "/infoStream" and "/infoStream/@file" elements but the toMap method does not write them.

Would that be intended or is it maybe an unintended omission? If intended would be great to
have a comment in toMap to clarify why/which elements are skipped, so that if/when a new element
is added its easier to determine if toMap should write the new element also.
{quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message