lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6646) make the EarlyTerminatingSortingCollector constructor SortingMergePolicy-free
Date Thu, 02 Jul 2015 12:52:05 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611907#comment-14611907
] 

ASF GitHub Bot commented on LUCENE-6646:
----------------------------------------

GitHub user cpoerschke opened a pull request:

    https://github.com/apache/lucene-solr/pull/178

    LUCENE-6646: SortingMergePolicy-free EarlyTerminatingSortingCollector constructor

    for https://issues.apache.org/jira/i#browse/LUCENE-6646

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bloomberg/lucene-solr trunk-etsc-lucene

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #178
    
----
commit 7881a5931cf8db8a76f1aee9ca747f6b8de2a63a
Author: Christine Poerschke <cpoerschke@bloomberg.net>
Date:   2015-06-29T15:02:44Z

    LUCENE-6646: make the EarlyTerminatingSortingCollector constructor SortingMergePolicy-free
    
    motivation:
     * SOLR-5730 to make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector
configurable in Solr.
     * outline of draft SOLR-5730 changes:
       + SolrIndexWriter constructor calls SolrIndexConfig.toIndexWriterConfig (passing the
result to its lucene.IndexWriter super class)
       + SolrIndexConfig.toIndexWriterConfig(SolrCore core) calls SolrIndexConfig.buildMergePolicy
       + SolrIndexConfig.buildMergePolicy(IndexSchema schema) calls the SortingMergePolicy
constructor (using the IndexSchema's mergeSortSpec)
       + SolrIndexSearcher.buildAndRunCollectorChain calls the EarlyTerminatingSortingCollector
constructor (using the IndexSchema's mergeSortSpec)
    
    summary of changes:
     * made SortingMergePolicy's isSorted into a static function
     * made EarlyTerminatingSortingCollector's constructor SortingMergePolicy-free, class
summary docs updated to match
     * adjusted EarlyTerminatingSortingCollector.canEarlyTerminate to be SortingMergePolicy-free
also
     * corresponding changes to TestEarlyTerminatingSortingCollector
     * adjusted AnalyzingInfixSuggester's EarlyTerminatingSortingCollector constructor call

----


> make the EarlyTerminatingSortingCollector constructor SortingMergePolicy-free
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-6646
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6646
>             Project: Lucene - Core
>          Issue Type: Wish
>            Reporter: Christine Poerschke
>            Priority: Minor
>
> motivation and summary of proposed changes to follow via github pull request



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message