lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6650) Remove dependency of lucene/spatial on oal.search.Filter
Date Mon, 06 Jul 2015 04:43:04 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614534#comment-14614534
] 

David Smiley commented on LUCENE-6650:
--------------------------------------

bq. Maybe we could even make this method final and return a QueryWrapperFilter around the
result of makeQuery? 

+1

bq. I know that some spatial filters throw an exception when someone tries to pull an iterator.
I don't think a similar behaviour would be necessary anymore given that we have tests that
BooleanQuery takes advantage of approximations when they are available, while FilteredQuery
could still use an inefficient iterator if you did not configure the appropriate FilterStrategy?

Right; not necessary.  The only spatial filter that applies here is via SerializedDVStrategy.
 In the patch I post I may even enhance SerializedDVStrategy to use TwoPhaseIterator.

> Remove dependency of lucene/spatial on oal.search.Filter
> --------------------------------------------------------
>
>                 Key: LUCENE-6650
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6650
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: David Smiley
>
> We should try to remove usage of oal.search.Filter in lucene/spatial. I gave it a try
but this module makes non-trivial use of filters so I wouldn't mind some help here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message