lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <>
Subject [jira] [Commented] (LUCENE-6650) Remove dependency of lucene/spatial on
Date Wed, 01 Jul 2015 20:19:04 GMT


Adrien Grand commented on LUCENE-6650:

Thanks David! This issue is mostly important for trunk indeed, but backporting to 5.x and
deprecating the old stuff would be nice too.

bq. on 5x SpatialStrategy.makeFilter can be deprecated (for back-compat)

+1 Maybe we could even make this method final and return a QueryWrapperFilter around the result
of makeQuery? Since QueryWrapperFilter rewrites to the wrapped query and FilteredQuery rewrites
to a BooleanQuery, this means that running a FilteredQuery with the result of makeFilter or
a BooleanQuery with a FILTER clause with the result of makeQuery would do exactly the same

I know that some spatial filters throw an exception when someone tries to pull an iterator.
I don't think a similar behaviour would be necessary anymore given that we have tests that
BooleanQuery takes advantage of approximations when they are available, while FilteredQuery
could still use an inefficient iterator if you did not configure the appropriate FilterStrategy?

> Remove dependency of lucene/spatial on
> --------------------------------------------------------
>                 Key: LUCENE-6650
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: David Smiley
> We should try to remove usage of in lucene/spatial. I gave it a try
but this module makes non-trivial use of filters so I wouldn't mind some help here.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message