lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6652) Remove tons of BytesRefAttribute/BytesRefAttributeImpl duplicates in tests
Date Thu, 02 Jul 2015 15:08:05 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612052#comment-14612052
] 

ASF subversion and git services commented on LUCENE-6652:
---------------------------------------------------------

Commit 1688845 from [~thetaphi] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1688845 ]

Merged revision(s) 1688830 from lucene/dev/trunk:
LUCENE-6653, LUCENE-6652: Refactor TermToBytesRefAttribute; add oal.analysis.tokenattributes.BytesTermAttribute;
remove code duplication in tests

> Remove tons of BytesRefAttribute/BytesRefAttributeImpl duplicates in tests
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-6652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6652
>             Project: Lucene - Core
>          Issue Type: Test
>    Affects Versions: 5.2.1
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 5.3, Trunk
>
>
> While implementing LUCENE-6651, I found a lot of duplicates of the same class (in different
variants) which is used by tests to generate binary terms. As we now have support for binary
terms in Field class itsself, we should remove all of those attributes accross tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message