lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lev Priima (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4212) Tests should not use new Random() without args
Date Thu, 20 Aug 2015 11:01:46 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704685#comment-14704685
] 

Lev Priima commented on LUCENE-4212:
------------------------------------

Also randomisation framework should print/log randomisation seed and be able to initialise
random seed from system property (or file, or etc) to simplify test failures reproduction
.

As it's made here:
http://hg.openjdk.java.net/jdk9/dev/hotspot/file/6f56da5908e6/test/testlibrary/jdk/test/lib/Utils.java#l357

> Tests should not use new Random() without args
> ----------------------------------------------
>
>                 Key: LUCENE-4212
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4212
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Robert Muir
>             Fix For: 4.0-ALPHA, Trunk
>
>         Attachments: LUCENE-4212.patch, LUCENE-4212.patch, LUCENE-4212.patch, LUCENE-4212.patch
>
>
> They should be using random() etc, and if they create one, it should pass in a seed.
> Otherwise, they probably won't reproduce.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message