lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ishan Chattopadhyaya (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-6625) Add interceptor API for outgoing calls through HttpSolrClient
Date Mon, 03 Aug 2015 15:07:06 GMT

     [ https://issues.apache.org/jira/browse/SOLR-6625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ishan Chattopadhyaya updated SOLR-6625:
---------------------------------------
    Attachment: SOLR-6625-revert.patch

Close to 5.3, I am feeling unsure of what else is broken. Since SOLR-7692 can use the serverside
request object (SolrRequestObject) directly from SolrRequestInfo, I want to revert the SolrHttpContext
and the SolrHttpClient parts from this issue. We'll still continue to have the HttpRequestInterceptor
support and the tests.

Here's a patch to do the same. The tests are passing for me.

If, at a later point, we need client side request object (SolrRequest), we can bring back
these changes with more tests. Right now, that seems not necessary.

> Add interceptor API for outgoing calls through HttpSolrClient
> -------------------------------------------------------------
>
>                 Key: SOLR-6625
>                 URL: https://issues.apache.org/jira/browse/SOLR-6625
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>            Reporter: Gregory Chanan
>            Assignee: Noble Paul
>            Priority: Minor
>         Attachments: SOLR-6625-revert.patch, SOLR-6625-testfailure.log, SOLR-6625-testfix.patch,
SOLR-6625-testfix.patch, SOLR-6625-testfix.patch, SOLR-6625-testfix.patch, SOLR-6625-testfix.patch,
SOLR-6625.patch, SOLR-6625.patch, SOLR-6625.patch, SOLR-6625.patch, SOLR-6625.patch, SOLR-6625.patch,
SOLR-6625.patch, SOLR-6625.patch, SOLR-6625_SolrReqPropogate.patch, SOLR-6625_interceptor.patch,
SOLR-6625_interceptor.patch, SOLR-6625_interceptor.patch, SOLR-6625_interceptor.patch, SOLR-6625_interceptor.patch,
SOLR-6625_interceptor.patch, SOLR-6625_interceptor.patch, SOLR-6625_interceptor.patch, SOLR-6625_interceptor.patch,
SOLR-6625_interceptor.patch, SOLR-6625_r1654079.patch, SOLR-6625_r1654079.patch
>
>
> Some of our setups use Solr in a SPNego/kerberos setup (we've done this by adding our
own filters to the web.xml).  We have an issue in that SPNego requires a negotiation step,
but some HttpSolrServer requests are not repeatable, notably the PUT/POST requests.  So, what
happens is, HttpSolrServer sends the requests, the server responds with a negotiation request,
and the request fails because the request is not repeatable.  We've modified our code to send
a repeatable request beforehand in these cases.
> It would be nicer if HttpSolrServer provided a pre/post callback when it was making an
httpclient request.  This would allow administrators to make changes to the request for authentication
purposes, and would allow users to make per-request changes to the httpclient calls (i.e.
modify httpclient requestconfig to modify the timeout on a per-request basis).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message