lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl (JIRA) <j...@apache.org>
Subject [jira] [Commented] (SOLR-7043) Refactor SolrCLI, bin\solr, bin\solr.cmd to be more unit-testable and less OS specific
Date Tue, 04 Aug 2015 16:25:04 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653909#comment-14653909
] 

Jan Høydahl commented on SOLR-7043:
-----------------------------------

bq. I do like the idea of having a configuration file for Solr startup, but it should be in
one of the two config languages which are predominant in Solr already – .xml and .properties.
I cannot debate on the technical merits of yml, because I know nothing at all about it.

Both YML and .properties are nice since they are less verbose than XML/JSON. You can simply
start typing key:value pairs one per line, exactly like in the current solr.in.* files. YML
has the benefit over .properties in that it supports lists and other data types should that
be needed later. If we go for YML it could be {{solr.yml}}, but we should not name it {{solr.properties}}
since that can be confused with {{$SOLR_HOME/solr.properties}}.

> Refactor SolrCLI, bin\solr, bin\solr.cmd to be more unit-testable and less OS specific
> --------------------------------------------------------------------------------------
>
>                 Key: SOLR-7043
>                 URL: https://issues.apache.org/jira/browse/SOLR-7043
>             Project: Solr
>          Issue Type: Improvement
>          Components: scripts and tools
>            Reporter: Timothy Potter
>            Assignee: Timothy Potter
>
> With the 5.0 release, we've reached critical mass with the bin/solr script interface,
but we've picked up some cruft along the way. Specifically, there's too much OS-specific constructs
in the scripts and they are quite complex overall. They also require extensive manual testing.
Moreover, SolrCLI (provides support for the scripts) needs to be refactored to use the Collections
API support added to SolrJ instead of using low-level JSON / HTTP constructs. SolrCLI is also
in desperate need of a unit test. The overall goal of this ticket is to move as much as possible
out of the shell scripts and into SolrCLI, thus increasing test coverage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message