lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] [Commented] (LUCENE-6417) Upgrade ANTLR to version 4.5
Date Tue, 04 Aug 2015 08:35:05 GMT


Uwe Schindler commented on LUCENE-6417:

Thanks Jack! I am fine with the patch! Only the Deque<Type> declaration should be final
(no new patch needed).

About the assembly: I was expecting this, I just wanted to make sure that the refactoring
caused no changes. Maybe dump the class files to disk for old and new and compare afterwards
- but if tests work as expected, we should be quite safe - maybe we need some random stuff
here (with lots of recursions).

Robert and I dumped the class files when we refactored this 2 years ago.

> Upgrade ANTLR to version 4.5
> ----------------------------
>                 Key: LUCENE-6417
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Jack Conradson
>         Attachments: LUCENE-6471.patch, LUCENE-6471.patch
> I would like to upgrade ANTLR from 3.5 to 4.5.  This version adds several features that
will improve the existing grammars.  The main improvement would be the allowance of left-hand
recursion in grammar rules which will reduce the number of rules significantly for expressions.
> This change will require some code refactoring to the existing expressions work.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message