lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jack Conradson (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-6417) Upgrade ANTLR to version 4.5
Date Tue, 04 Aug 2015 23:11:04 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654495#comment-14654495
] 

Jack Conradson edited comment on LUCENE-6417 at 8/4/15 11:10 PM:
-----------------------------------------------------------------

Uwe, would it be possible to move the implemented visitor methods from the JavascriptCompiler
into a private static inner class inside of the JavascriptCompiler to hide them properly and
then make all the other public classes package protected through regexs like we already do
for some of the classes in the build.xml file?  Would this satisfy the requirements of keeping
all the ANTLR methods hidden or is there more that I'm missing?

The other option that I can think of is to go back to parsing the raw tree again, but I prefer
to avoid this if possible due to changes in the tree structures between ANTLR 3 and 4.

Please let me know what you think.


was (Author: jdconradson):
Uwe, would it be possible to move the implemented visitor methods from the JavascriptCompiler
into a private static inner class inside of the JavascriptCompiler to hide them properly and
then make all the other public classes package protected through regexs like we already do
for some of the classes in the build.xml file?  Would this satisfy the requirements of keeping
all the ANTLR methods hidden or is there more that I'm missing?

> Upgrade ANTLR to version 4.5
> ----------------------------
>
>                 Key: LUCENE-6417
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6417
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Jack Conradson
>            Assignee: Uwe Schindler
>         Attachments: LUCENE-6471.patch, LUCENE-6471.patch, LUCENE-6471.patch
>
>
> I would like to upgrade ANTLR from 3.5 to 4.5.  This version adds several features that
will improve the existing grammars.  The main improvement would be the allowance of left-hand
recursion in grammar rules which will reduce the number of rules significantly for expressions.
> This change will require some code refactoring to the existing expressions work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message