lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-6417) Upgrade ANTLR to version 4.5
Date Thu, 06 Aug 2015 21:14:07 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler updated LUCENE-6417:
----------------------------------
    Attachment: LUCENE-6417.patch

Hi,
patch looks good. I did some minor changes at the visibility of the JavascriptCompiler fields
to prevent {{acess$X}} methods (Eclipse warning about synthetic access) and imported everything
successfully into subversion. I also changed the visibility of the error listeners/handlers
to pkg private, the javadocs now look identical to before.

"ant precommit" passes and all maven dependencies are fine.

"ant regenerate" recreates the files without overriding my visibility changes.

I will run all tests tomorrow and commit, it's too late now. Thanks Jack!

> Upgrade ANTLR to version 4.5
> ----------------------------
>
>                 Key: LUCENE-6417
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6417
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Jack Conradson
>            Assignee: Uwe Schindler
>         Attachments: LUCENE-6417.patch, LUCENE-6417.patch, LUCENE-6471.patch, LUCENE-6471.patch,
LUCENE-6471.patch
>
>
> I would like to upgrade ANTLR from 3.5 to 4.5.  This version adds several features that
will improve the existing grammars.  The main improvement would be the allowance of left-hand
recursion in grammar rules which will reduce the number of rules significantly for expressions.
> This change will require some code refactoring to the existing expressions work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message