lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christine Poerschke (JIRA)" <>
Subject [jira] [Commented] (LUCENE-6691) tweak SortingMergePolicy.getSortDescription
Date Mon, 03 Aug 2015 13:13:04 GMT


Christine Poerschke commented on LUCENE-6691:

Have chosen 'Changes in Runtime Behavior' on the basis that the code is in 'misc' rather than
'core' and {{FilterLeafReader}} previously not being considered is not so much a bug but known-to-be-unsupported
behavior. Happy to change to another section though if 'Changes in Runtime Behavior' was the
wrong choice.

> tweak SortingMergePolicy.getSortDescription
> -------------------------------------------
>                 Key: LUCENE-6691
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
> Building tests for SOLR-5730 identified that early termination can be omitted for sorted
segments because the {{LeafReader}} concerned is not a {{SegmentReader}} - github pull request
to illustrate to follow:
> * the {{TestEarlyTerminatingSortingCollector.testTerminatedEarly}} test uses a wrapped
reader in the same way as {{SolrIndexSearcher}}
> * the {{SortingMergePolicy.getSortDescription}} change (assuming it is a valid change
to make) fixes that particular test only
> * {{ExitableDirectoryReader}} and {{UninvertingReader}} wrap could perhaps also be added
in {{LuceneTestCase.wrapReader}} ?
> LUCENE-6065 "remove "foreign readers" from merge, fix LeafReader instead." also concerns

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message