lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6691) tweak SortingMergePolicy.getSortDescription
Date Tue, 04 Aug 2015 16:11:05 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653880#comment-14653880
] 

ASF GitHub Bot commented on LUCENE-6691:
----------------------------------------

Github user cpoerschke closed the pull request at:

    https://github.com/apache/lucene-solr/pull/191


> tweak SortingMergePolicy.getSortDescription
> -------------------------------------------
>
>                 Key: LUCENE-6691
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6691
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>
> Building tests for SOLR-5730 identified that early termination can be omitted for sorted
segments because the {{LeafReader}} concerned is not a {{SegmentReader}} - github pull request
to illustrate to follow:
> * the {{TestEarlyTerminatingSortingCollector.testTerminatedEarly}} test uses a wrapped
reader in the same way as {{SolrIndexSearcher}}
> * the {{SortingMergePolicy.getSortDescription}} change (assuming it is a valid change
to make) fixes that particular test only
> * {{ExitableDirectoryReader}} and {{UninvertingReader}} wrap could perhaps also be added
in {{LuceneTestCase.wrapReader}} ?
> LUCENE-6065 "remove "foreign readers" from merge, fix LeafReader instead." also concerns
SortingMergePolicy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message