lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-7859) Clamp down on use of System.currentTimeMillis
Date Sun, 09 Aug 2015 13:15:46 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679137#comment-14679137
] 

Erik Hatcher commented on SOLR-7859:
------------------------------------

This commit broke bin/post, which relies on SimplePostTool.  The issue is that RTimer refers
to NamedList which isn't in the classpath used by the SimplePostTool startup:

{code}
$ bin/post -c files ~/Documents
java -classpath /Users/erikhatcher/dev/lucene-trunk/solr/dist/solr-core-6.0.0-SNAPSHOT.jar
-Dauto=yes -Dc=files -Ddata=files -Drecursive=yes org.apache.solr.util.SimplePostTool /Users/erikhatcher/Documents/Lucidworks/
SimplePostTool version 5.0.0
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/solr/common/util/NamedList
	at org.apache.solr.util.SimplePostTool.execute(SimplePostTool.java:176)
	at org.apache.solr.util.SimplePostTool.main(SimplePostTool.java:167)
{code}

The best fix is probably to have bin/post also include the SolrJ library.

And yes, there needs to be a test for bin/post - created SOLR-7901 for this task.

> Clamp down on use of System.currentTimeMillis
> ---------------------------------------------
>
>                 Key: SOLR-7859
>                 URL: https://issues.apache.org/jira/browse/SOLR-7859
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ramkumar Aiyengar
>            Assignee: Ramkumar Aiyengar
>         Attachments: SOLR-7859.patch, SOLR-7859.patch, SOLR-7859.patch
>
>
> We did one round of this in SOLR-5734, but more places seem to keep cropping up. We should
do one more round, and start whitelisting places which really need it using forbidden-apis.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message