lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomás Fernández Löbbe (JIRA) <j...@apache.org>
Subject [jira] [Commented] (SOLR-7875) Speedup SolrQueryTimeoutImpl
Date Thu, 06 Aug 2015 16:40:04 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660274#comment-14660274
] 

Tomás Fernández Löbbe commented on SOLR-7875:
---------------------------------------------

If we leave the unset value as null (instead of nanoTime() + nanoTime() + Long.MAX_VALUE)
and we do a null check in the shouldExit() method there is already a big improvement. Still
not as good as without the ExitableDirectoryReader wrapper:

|| ||Solr-5_3_0-Not-Exitable-1 || Solr-5_3_0-Not-Exitable-2 ||	Solr-5_3_0-Exitable-1 ||	Solr-5_3_0-Exitable-2
||	Solr-5_3_0-branch5-1 ||	Solr-5_3_0-branch5-2 ||
| Average	| 395 | 393	 | 442	 | 440	 | 2603 | 	2595
| p10 | 	95	| 90	 | 105	 | 103	 | 558	 | 551
| p50 | 	380	| 378 | 	426	 | 423	 | 2520	 | 2507
| p75 | 	581	| 579	 | 646	 | 645	 | 3839	 | 3839
| p90 | 	707	| 706	 | 789	 | 788	 | 4710	 | 4698
| p95 | 	782	| 778	 | 870	 | 870	 | 5234	 | 5232
| p99	 | 989	| 984	 | 1104	 | 1105	 | 6671	 | 6700

This is with a test that runs 3k boolean queries with filters on double fields (more details
in the email thread linked in the description of the ticket). 
* Solr-5_3_0-Not-Exitable-# is a snapshot of 5x branch that completely skips the ExitableDirectoryReader
wrapping
* Solr-5_3_0-Exitable-# is the same snapshot but with the patch that does the null checks.
* Solr-5_3_0-branch5-# is the same snapshot but without any changes. 

> Speedup SolrQueryTimeoutImpl
> ----------------------------
>
>                 Key: SOLR-7875
>                 URL: https://issues.apache.org/jira/browse/SOLR-7875
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 5.0, 5.1, 5.2, 5.2.1
>            Reporter: Tomás Fernández Löbbe
>         Attachments: SOLR-7875.patch
>
>
> SolrQueryTimeoutImpl can be slow for some use cases, for example, in cases with many
terms, where shouldExit() is called many times. 
> See http://search-lucene.com/m/l6pAi1HLrodLhNUd



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message