lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (LUCENE-6755) more tests of ToChildBlockJoinScorer.advance
Date Thu, 20 Aug 2015 18:10:45 GMT


ASF subversion and git services commented on LUCENE-6755:

Commit 1696834 from in branch 'dev/trunk'
[ ]

LUCENE-6755: more tests of ToChildBlockJoinScorer.advance

> more tests of ToChildBlockJoinScorer.advance
> --------------------------------------------
>                 Key: LUCENE-6755
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Hoss Man
> I recently helped diagnose some strange errors with ToChildBlockJoinQuery in an older
version of Solr which lead me to realize that the problem seemed to have been fixed by LUCENE-6593
-- however the tests Adrien added in that issue focused specifically the interaction of ToChildBlockJoinScorer
with with the (fairly new) aproximations support in Scorers (evidently that was trigger that
caused Adrien to investigate and make the fixes).
> However, in my initial diagnoses / testing, there were at least 2 (non aproximation based)
situations where the _old_ code was problematic:
> * ToChildBlockJoinScorer.advance didn't satisfy the "nextDoc equivilent behavior" contract
in the special case where the first doc in a segment was a parent w/o any kids
> * in indexes that used multiple levels of hierarchy, a BooleanQuery that combined multiple
ToChildBlockJoinQueries using different parent filters -- ie: "find docs that are _children_
of X and _grandchildren_ of Y"
> As mentioned, Adrien's changes in LUCENE-6593 seemed to fix both of these problematic
situations, but I'm opening this issue to track the addition of some new tests to explicitly
cover these situations to protect us against future regression.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message