lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6759) Integrate lat/long BKD and spatial 3d, part 2
Date Thu, 27 Aug 2015 14:23:47 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716755#comment-14716755
] 

Karl Wright commented on LUCENE-6759:
-------------------------------------

Looks ok, except this doesn't seem like it should be there anymore:

{code}
+                                             if (cellXMaxEnc < Integer.MAX_VALUE) {
+                                               cellXMaxEnc++;
+                                             }
+                                             if (cellYMaxEnc < Integer.MAX_VALUE) {
+                                               cellYMaxEnc++;
+                                             }
+                                             if (cellZMaxEnc < Integer.MAX_VALUE) {
+                                               cellZMaxEnc++;
+                                             }
+
{code}

It seems like the cell*MaxEnc and cell*MinEnc values are all positive integers?



> Integrate lat/long BKD and spatial 3d, part 2
> ---------------------------------------------
>
>                 Key: LUCENE-6759
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6759
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Michael McCandless
>         Attachments: LUCENE-6699.patch, LUCENE-6699.patch, LUCENE-6699.patch, LUCENE-6699.patch,
LUCENE-6699.patch, LUCENE-6699.patch, LUCENE-6699.patch
>
>
> This is just a continuation of LUCENE-6699, which became too big.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message