lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adrien Grand <jpou...@gmail.com>
Subject Re: Strangeness with MultiSpansWrapper duplication
Date Fri, 16 Oct 2015 11:43:39 GMT
I just removed it.

Le jeu. 1 oct. 2015 à 09:44, Alan Woodward <alan@flax.co.uk> a écrit :

> Ugh, I think that's a merge error on my part.  You should be fine to nuke
> the lucene/core version.
>
> Alan Woodward
> www.flax.co.uk
>
>
> On 1 Oct 2015, at 01:06, Shawn Heisey wrote:
>
> In branch_5x, the MultiSpansWrapper.java file exists in two places.  I
> only noticed this because of an error in eclipse.  The two files look
> identical.  This doesn't seem to cause any actual problems with the
> build, just the IDE error.
>
> One copyishere:
>
>
> lucene/test-framework/src/java/org/apache/lucene/search/spans/MultiSpansWrapper.java
>
> The other is here:
>
> lucene/core/src/test/org/apache/lucene/search/spans/MultiSpansWrapper.java
>
> It appears that trunk doesn't have this problem, and only the copy in
> test-framework exists.
>
> Here is a patch that removes the extra copy in 5.x:
>
> https://www.dropbox.com/s/tij4ckt84l971hx/nuke-multispans.patch?dl=0
>
> I can open an issue and remove the extra file, if everyone thinks that's
> a good idea.  The core tests passed with this patch applied, but the
> benchmark tests failed with an access denied problem that seems
> completely unrelated.  I will pound on it some more to be sure I don't
> see any problems.
>
> Thanks,
> Shawn
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
>

Mime
View raw message