lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-6271) ConjunctionSolrSpellChecker wrong check for same string distance
Date Fri, 04 Dec 2015 18:10:10 GMT

    [ https://issues.apache.org/jira/browse/SOLR-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041891#comment-15041891
] 

ASF GitHub Bot commented on SOLR-6271:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/lucene-solr/pull/135


> ConjunctionSolrSpellChecker wrong check for same string distance
> ----------------------------------------------------------------
>
>                 Key: SOLR-6271
>                 URL: https://issues.apache.org/jira/browse/SOLR-6271
>             Project: Solr
>          Issue Type: Bug
>          Components: spellchecker
>    Affects Versions: 4.9
>            Reporter: Igor Kostromin
>            Assignee: James Dyer
>         Attachments: SOLR-6271.patch, SOLR-6271.patch
>
>
> See ConjunctionSolrSpellChecker.java
> try {
>       if (stringDistance == null) {
>         stringDistance = checker.getStringDistance();
>       } else if (stringDistance != checker.getStringDistance()) {
>         throw new IllegalArgumentException(
>             "All checkers need to use the same StringDistance.");
>       }
>     } catch (UnsupportedOperationException uoe) {
>       // ignore
>     }
> In line stringDistance != checker.getStringDistance() there is comparing by references.
So if you are using 2 or more spellcheckers with same distance algorithm, exception will be
thrown anyway.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message