lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2798) Local Param parsing does not support multivalued params
Date Thu, 14 Jan 2016 17:43:40 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098486#comment-15098486
] 

ASF GitHub Bot commented on SOLR-2798:
--------------------------------------

GitHub user demiankatz opened a pull request:

    https://github.com/apache/lucene-solr/pull/216

    Resolution for SOLR-2798 (add support for multi-valued localParams)

    Previous to this fix, when using localParams syntax, a repeated parameter would be handled
with a "last value wins" policy. This PR changes the behavior to allow all values of the parameter
to be accepted, which seems like it should be the expected behavior, since many Solr parameters
are intended to be repeatable.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/demiankatz/lucene-solr solr-2798-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #216
    
----
commit b991e72b04a4de4c35f4fa1dc1338eafb67756d8
Author: Demian Katz <demian.katz@villanova.edu>
Date:   2016-01-13T19:43:13Z

    Allow parseLocalParams to target a ModifiableSolrParams object.
    - Progress on SOLR-2798.

commit 314a58c593de4cf7ed80bffc7b3e8034d17143be
Author: Demian Katz <demian.katz@villanova.edu>
Date:   2016-01-13T20:06:37Z

    Switch calls to parseLocalParams to use ModifiableSolrParams instead of Map.
    - See SOLR-2798.

commit 107f6224aa33edea08a961adcb2e57b2cc96e69e
Author: Demian Katz <demian.katz@villanova.edu>
Date:   2016-01-14T14:12:27Z

    Deprecated obsolete methods; added comments.

commit ed544b6d726e4e79319cfb5808cc3fdfde6e0f26
Author: Demian Katz <demian.katz@villanova.edu>
Date:   2016-01-14T14:51:24Z

    Added higher-level test for localParams fix.

----


> Local Param parsing does not support multivalued params
> -------------------------------------------------------
>
>                 Key: SOLR-2798
>                 URL: https://issues.apache.org/jira/browse/SOLR-2798
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Anshum Gupta
>
> As noted by Demian on the solr-user mailing list, Local Param parsing seems to use a
"last one wins" approach when parsing multivalued params.
> In this example, the value of "111" is completely ignored:
> {code}
> http://localhost:8983/solr/select?debug=query&q={!dismax%20bq=111%20bq=222}foo
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message