lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8359) Restrict child classes from using parent logger's state
Date Wed, 20 Jan 2016 22:41:39 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109633#comment-15109633
] 

Yonik Seeley commented on SOLR-8359:
------------------------------------

Why were the non-statics changed to statics?
I just ran across an issue w/ peersync where I couldn't change the debug level dynamically.

> Restrict child classes from using parent logger's state
> -------------------------------------------------------
>
>                 Key: SOLR-8359
>                 URL: https://issues.apache.org/jira/browse/SOLR-8359
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Mike Drob
>            Assignee: Anshum Gupta
>             Fix For: 5.5, Trunk
>
>         Attachments: SOLR-8359-nonfinal-values.patch, SOLR-8359.patch, SOLR-8359.patch
>
>
> In SOLR-8330 we split up a lot of loggers. However, there are a few classes that still
use their parent's logging state and configuration indirectly.
> {{HdfsUpdateLog}} and {{HdfsTransactionLog}} both use their parent class cached read
of {{boolean debug = log.isDebugEnabled()}}, when they should check their own loggers instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message