lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-8453) Local exceptions in DistributedUpdateProcessor should not cut off an ongoing request.
Date Mon, 04 Jan 2016 19:00:40 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081576#comment-15081576
] 

Yonik Seeley edited comment on SOLR-8453 at 1/4/16 7:00 PM:
------------------------------------------------------------

bq. That's unfortunate if one can't provide an error response before the request has finished.

Hmmm, OK... it doesn't look like that's happening:

{code}
~$ nc 127.0.0.1 8983
POST /solr/techproducts/update HTTP/1.1
Host: localhost:8983
User-Agent: curl/7.43.0
Accept: */*
Content-type:application/json
Content-Length: 1000000000


[
 {"id_not_exist" : "TestDoc1", "title" : "test1"},
{code}
{code}
HTTP/1.1 400 Bad Request
Content-Type: text/plain;charset=utf-8
Transfer-Encoding: chunked

7E
{"responseHeader":{"status":400,"QTime":6312},"error":{"msg":"Document is missing mandatory
uniqueKey field: id","code":400}}

0
{code}


was (Author: yseeley@gmail.com):
bq. That's unfortunate if one can't provide an error response before the request has finished.

Hmmm, OK... it doesn't look like that's happening:

~$ nc 127.0.0.1 8983
POST /solr/techproducts/update HTTP/1.1
Host: localhost:8983
User-Agent: curl/7.43.0
Accept: */*
Content-type:application/json
Content-Length: 1000000000


[
 {"id_not_exist" : "TestDoc1", "title" : "test1"},
HTTP/1.1 400 Bad Request
Content-Type: text/plain;charset=utf-8
Transfer-Encoding: chunked

7E
{"responseHeader":{"status":400,"QTime":6312},"error":{"msg":"Document is missing mandatory
uniqueKey field: id","code":400}}

0


> Local exceptions in DistributedUpdateProcessor should not cut off an ongoing request.
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-8453
>                 URL: https://issues.apache.org/jira/browse/SOLR-8453
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>         Attachments: SOLR-8453.patch, SOLR-8453.patch, SOLR-8453.patch, SOLR-8453.patch,
SOLR-8453.patch, SOLR-8453.patch, SOLR-8453.patch
>
>
> The basic problem is that when we are streaming in updates via a client, an update can
fail in a way that further updates in the request will not be processed, but not in a way
that causes the client to stop and finish up the request before the server does something
else with that connection.
> This seems to mean that even after the server stops processing the request, the concurrent
update client is still in the process of sending the request. It seems previously, Jetty would
not go after the connection very quickly after the server processing thread was stopped via
exception, and the client (usually?) had time to clean up properly. But after the Jetty upgrade
from 9.2 to 9.3, Jetty closes the connection on the server sooner than previous versions (?),
and the client does not end up getting notified of the original exception at all and instead
hits a connection reset exception. The result was random fails due to connection reset throughout
our tests and one particular test failing consistently. Even before this update, it does not
seem like we are acting in a safe or 'behaved' manner, but our version of Jetty was relaxed
enough (or a bug was fixed?) for our tests to work out.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message