lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8475) Some refactoring to SolrIndexSearcher
Date Mon, 04 Jan 2016 15:33:39 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081278#comment-15081278
] 

Yonik Seeley commented on SOLR-8475:
------------------------------------

bq. About the back-compat, I think that's a small enough change and it makes sense to do that
in 5x too.

I'm not sure I understand the standard being applied here.  The size of a change, or how easy
it will be to convert plugin code doesn't seem that relevant when discussing back compat.
QueryCommand/QueryResponse are top level classes likely to be used by plugins.  We have always
had a back compat policy of remaining back compat for "major" Java interfaces across minor
versions.

If we wish to discontinue, change, or clarify that policy, there should probably be a discussion
on the mailing lists to come to consensus (it will get lost in this issue).


> Some refactoring to SolrIndexSearcher
> -------------------------------------
>
>                 Key: SOLR-8475
>                 URL: https://issues.apache.org/jira/browse/SOLR-8475
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 5.5, Trunk
>
>         Attachments: SOLR-8475.patch, SOLR-8475.patch, SOLR-8475.patch, SOLR-8475.patch,
SOLR-8475.patch
>
>
> While reviewing {{SolrIndexSearcher}}, I started to correct a thing here and there, and
eventually it led to these changes:
> * Moving {{QueryCommand}} and {{QueryResult}} to their own classes.
> * Moving FilterImpl into a private static class (was package-private and defined in the
same .java file, but separate class).
> * Some code formatting, imports organizing and minor log changes.
> * Removed fieldNames (handled the TODO in the code)
> * Got rid of usage of deprecated classes such as {{LegacyNumericUtils}} and {{Legacy-*-Field}}.
> I wish we'd cut down the size of this file much more (it's 2500 lines now), but I've
decided to stop here so that the patch is manageable. I would like to explore further refactorings
afterwards, e.g. extracting cache management code to an outer class (but keep {{SolrIndexSearcher}}'s
API the same, if possible).
> If you have additional ideas of more cleanups / simplifications, I'd be glad to do them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message