lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8485) SelectStream only works with all lowercase field names and doesn't handle quoted selected fields
Date Fri, 08 Jan 2016 01:55:40 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088575#comment-15088575
] 

ASF subversion and git services commented on SOLR-8485:
-------------------------------------------------------

Commit 1723648 from dpgove@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r1723648 ]

SOLR-8485: SelectStream now properly handles non-lowercase and/or quoted select field names

> SelectStream only works with all lowercase field names and doesn't handle quoted selected
fields
> ------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8485
>                 URL: https://issues.apache.org/jira/browse/SOLR-8485
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Dennis Gove
>            Assignee: Dennis Gove
>            Priority: Minor
>              Labels: streaming
>         Attachments: SOLR-8485.patch, SOLR-8485.patch, SOLR-8485.patch
>
>
> Three issues exist if one creates a SelectStream with an expression.
> {code}
> select(
>   search(collection1, fl="personId_i,rating_f", q="rating_f:*", sort="personId_i asc"),
>   personId_i as personId,
>   rating_f as rating
> )
> {code}
> "personId_i as personId" will be parsed as "personid_i as personid"
> 1. The incoming tuple will contain a field "personId_i" but the selection will be looking
for a field "personid_i". This field won't be found in the incoming tuple (notice the case
difference) and as such no field personId will exist in the outgoing tuple.
> 2. If (1) wasn't an issue, the outgoing tuple would have in a field "personid" and not
the expected "personId" (notice the case difference). This can lead to other down-the-road
issues.
> 3. Also, if one were to quote the selected fields such as in
> {code}
> select(
>   search(collection1, fl="personId_i,rating_f", q="rating_f:*", sort="personId_i asc"),
>   "personId_i as personId",
>   "rating_f as rating"
> )
> {code}
> then the quotes would be included in the field name. Wrapping quotes should be handled
properly such that they are removed from the parameters before they are parsed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message