lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6965) Expression's JavascriptCompiler to throw ParseExceptions with bad function names or arity
Date Thu, 07 Jan 2016 23:38:39 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088389#comment-15088389
] 

ASF subversion and git services commented on LUCENE-6965:
---------------------------------------------------------

Commit 1723642 from [~thetaphi] in branch 'dev/trunk'
[ https://svn.apache.org/r1723642 ]

LUCENE-6965: Changed exception handling in JavascriptCompiler using "sneaky rethrow"

> Expression's JavascriptCompiler to throw ParseExceptions with bad function names or arity
> -----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-6965
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6965
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Tomás Fernández Löbbe
>         Attachments: LUCENE-6965-2.patch, LUCENE-6965.patch, LUCENE-6965.patch, LUCENE-6965.patch
>
>
> Currently JavascriptCompiler will throw IllegalArgumentException for bad function names
(or functions that don't exist) and for bad arity. I can see why this was done this way, but
I believe ParseException would also be correct and it would be better since that's the exception
clients will be prepared to receive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message