lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6967) Fail the build on missing Override annotation
Date Thu, 07 Jan 2016 20:53:40 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088088#comment-15088088
] 

Michael McCandless commented on LUCENE-6967:
--------------------------------------------

+1 for a patch, thank you [~paul.elschot@xs4all.nl]!  But I'm also unsure how to handle the
gen'd sources.  Is it just the {{javacc}} generated code that's missing {{@Override}}?

> Fail the build on missing Override annotation
> ---------------------------------------------
>
>                 Key: LUCENE-6967
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6967
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Priority: Minor
>
> Spin-off of LUCENE-6957. Even though javac does not support it, ecj does with this one-liner:
> {noformat}
> --- lucene/tools/javadoc/ecj.javadocs.prefs	(revision 1723604)
> +++ lucene/tools/javadoc/ecj.javadocs.prefs	(working copy)
> @@ -47,7 +47,7 @@
>  org.eclipse.jdt.core.compiler.problem.missingJavadocTagsMethodTypeParameters=disabled
>  org.eclipse.jdt.core.compiler.problem.missingJavadocTagsOverriding=disabled
>  org.eclipse.jdt.core.compiler.problem.missingJavadocTagsVisibility=public
> -org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore
> +org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=error
>  org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled
>  org.eclipse.jdt.core.compiler.problem.missingSerialVersion=ignore
>  org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message