lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6835) Directory.deleteFile should "own" retrying deletions on Windows
Date Thu, 04 Feb 2016 03:07:40 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131636#comment-15131636
] 

Robert Muir commented on LUCENE-6835:
-------------------------------------

Thanks for attacking this! 

Should we add a TODO to IndexFileDeleter to try to remove the LUCENE-6684 hack later too?
I really like the sort (since we return array anyway). Can we followup by making this a change
to the Directory API? e.g. fix RAMDir etc to behave too. We can add tests to BaseDirectoryTestCase
that it works.
Lets remove those OS-specific heroics and move forward.



> Directory.deleteFile should "own" retrying deletions on Windows
> ---------------------------------------------------------------
>
>                 Key: LUCENE-6835
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6835
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>             Fix For: 5.5, master
>
>         Attachments: LUCENE-6835.patch, LUCENE-6835.patch
>
>
> Rob's idea:
> Today, we have hairy logic in IndexFileDeleter to deal with Windows file systems that
cannot delete still open files.
> And with LUCENE-6829, where OfflineSorter now must deal with the situation too ... I
worked around it by fixing all tests to disable the virus checker.
> I think it makes more sense to push this "platform specific problem" lower in the stack,
into Directory?  I.e., its deleteFile method would catch the access denied, and then retry
the deletion later.  Then we could re-enable virus checker on all these tests, simplify IndexFileDeleter,
etc.
> Maybe in the future we could further push this down, into WindowsDirectory,  and fix
FSDirectory.open to return WindowsDirectory on windows ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message