lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ramkumar Aiyengar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8371) Try and prevent too many recovery requests from stacking up and clean up some faulty logic.
Date Sat, 13 Feb 2016 23:09:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146242#comment-15146242
] 

Ramkumar Aiyengar commented on SOLR-8371:
-----------------------------------------

Sorry Mark, I completely missed your comments on my patch. The intent there was to have at
least one in the queue after the currently processing one (hence a fixed queue of size 1),
so yes, there will be at least one more attempt after the last request. And any other attempt
will just be rejected. But as I said, I haven't tested it -- I know the ArrayBlockingQueue
will block any queueing when it hits capacity, but the ThreadpoolExecutor docs say that when
a bound queue size is hit, an exception is thrown. The exception was my intention (so all
jobs won't be run), perhaps testing will show otherwise..

> Try and prevent too many recovery requests from stacking up and clean up some faulty
logic.
> -------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8371
>                 URL: https://issues.apache.org/jira/browse/SOLR-8371
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 5.5, master
>
>         Attachments: SOLR-8371-2.patch, SOLR-8371.patch, SOLR-8371.patch, SOLR-8371.patch,
SOLR-8371.patch, SOLR-8371.patch, SOLR-8371.patch, SOLR-8371.patch, SOLR-8371.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message