lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-6989) Implement MMapDirectory unmapping for coming Java 9 changes
Date Fri, 19 Feb 2016 22:43:18 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155033#comment-15155033
] 

Uwe Schindler edited comment on LUCENE-6989 at 2/19/16 10:42 PM:
-----------------------------------------------------------------

No, keep it open, as the final word is not yet spoken. The next changes in Java is underway.

In addition I have a small change for this commit, which makes code more easier to understand
(comes a bit later). I am also debugging issues with build 105 at the moment.

This issue is about master branch. The fixes in 5.x was just the "backport".


was (Author: thetaphi):
No, keep it open, as the final word is not yet spoken. The next changes in Java is underway.

In addition I have a small change for this commit, which makes code more easier to understand
(comes a bit later). I am also debugging issues with build 105 at the moment.

> Implement MMapDirectory unmapping for coming Java 9 changes
> -----------------------------------------------------------
>
>                 Key: LUCENE-6989
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6989
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: core/store
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>            Priority: Critical
>              Labels: Java9
>             Fix For: master
>
>         Attachments: LUCENE-6989-disable5x.patch, LUCENE-6989-disable5x.patch, LUCENE-6989.patch,
LUCENE-6989.patch, LUCENE-6989.patch, LUCENE-6989.patch
>
>
> Originally, the sun.misc.Cleaner interface was declared as "critical API" in [JEP 260|http://openjdk.java.net/jeps/260
]
> Unfortunately the decission was changed in favor of a oficially supported {{java.lang.ref.Cleaner}}
API. A side effect of this change is to move all existing {{sun.misc.Cleaner}} APIs into a
non-exported package. This causes our forceful unmapping to no longer work, because we can
get the cleaner instance via reflection, but trying to invoke it will throw one of the new
Jigsaw RuntimeException because it is completely inaccessible. This will make our forceful
unmapping fail. There are also no changes in Garbage collector, the problem still exists.
> For more information see this [mailing list thread|http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-January/thread.html#38243].
> This commit will likely be done, making our unmapping efforts no longer working. Alan
Bateman is aware of this issue and will open a new issue at OpenJDK to allow forceful unmapping
without using the now private sun.misc.Cleaner. The idea is to let the internal class sun.misc.Cleaner
implement the Runable interface, so we can simply cast to runable and call the run() method
to unmap. The code would then work. This will lead to minor changes in our unmapper in MMapDirectory:
An instanceof check and casting if possible.
> I opened this issue to keep track and implement the changes as soon as possible, so people
will have working unmapping when java 9 comes out. Current Lucene versions will no longer
work with Java 9.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message