lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christine Poerschke (JIRA)" <>
Subject [jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace <mergePolicy> with <mergePolicyFactory>
Date Fri, 05 Feb 2016 17:49:39 GMT


Christine Poerschke commented on SOLR-8621:

Hello [~shaie], thanks for taking a look.

bq. ... I think they can be private since they're used only in SolrIndexConfig

I had considered package-visibility but assumed/think it's not possible since SolrIndexConfig
is org.apache.solr.update and DefaultMergePolicyFactory is org.apache.solr.index. But your
second point would make this moot anyhow.

bq. ... in buildMPFromInfo we just create a new instance (i.e. new DefaultMPFactory().getMP()).

Yes, that totally makes sense. My focus had been on having a single unified place where 'default
merge policy-ness' is handled, changing the existing buildMergePolicy\[FromInfo\] code to
also use the new default factory simply hadn't appeared on the radar. Good find! I'll go make
that change.

Unrelated to the above, just pushed changes to {{MergePolicyFactoryArgs}} which will do away
with the need to change {{SolrPluginUtils}} but still keep MergePolicyFactoryArgs as an abstraction
which just happens to be implemented via a NamedList at the moment.

> solrconfig.xml: deprecate/replace <mergePolicy> with <mergePolicyFactory>
> -------------------------------------------------------------------------
>                 Key: SOLR-8621
>                 URL:
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
> *<mergePolicyFactory> end-user benefits:*
> * Lucene's UpgradeIndexMergePolicy can be configured in Solr
> * (with SOLR-5730) Lucene's SortingMergePolicy can be configured in Solr
> * customisability: arbitrary merge policies including wrapping/nested merge policies
can be created and configured
> *(proposed) roadmap:*
> * solr 5.5 introduces <mergePolicyFactory> support
> * solr 5.5(\?) deprecates (but maintains) <mergePolicy> support
> * solr 6.0(\?) removes <mergePolicy> support 
> +work-in-progress git branch:+ [master-solr-8621|]

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message