lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace <mergePolicy> with <mergePolicyFactory>
Date Sat, 06 Feb 2016 15:55:39 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135847#comment-15135847
] 

Shai Erera commented on SOLR-8621:
----------------------------------

About {{WrapperMergePolicyFactory}}, for it too I prefer that we keep the top-level concrete/exposed,
and leave {{Wrapper}} to be an implementation helper.

BTW, I thought that we can have {{wrapped.key}} optional and default to 'delegate' if one
isn't specified. Again, to simplify configuration for users, who in most cases will wrap a
simple MP factory. Opinions?

In terms of 5.5, I personally feel like what we have so far is very solid and already covers
all the MP scenarios I can think about. The factory itself lets you implement one from scratch
and configure it however you want. And we offer helper classes (Wrapper and Simple) if you
want to implement something on your own, but not from scratch. And we cover all currently
supported-by-Solr MPs.

So I'd rather we finish the work on this issue, so that 5.5 can really go out with it. We
still have a lot to do in terms of actually deprecating {{<mergePolicy>}} support, remove
in trunk, modify existing {{solrconfig.xml}}s etc. Then we want to expose SortingMPF (SOLR-5730),
though that can happen post 5.5 if we don't make it.

As I said in my previous comment, if we later discover that we want to make Simple/Wrapper
more concrete classes, we can always do that. Post 6.0 too.

> solrconfig.xml: deprecate/replace <mergePolicy> with <mergePolicyFactory>
> -------------------------------------------------------------------------
>
>                 Key: SOLR-8621
>                 URL: https://issues.apache.org/jira/browse/SOLR-8621
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>
> *<mergePolicyFactory> end-user benefits:*
> * Lucene's UpgradeIndexMergePolicy can be configured in Solr
> * (with SOLR-5730) Lucene's SortingMergePolicy can be configured in Solr
> * customisability: arbitrary merge policies including wrapping/nested merge policies
can be created and configured
> *(proposed) roadmap:*
> * solr 5.5 introduces <mergePolicyFactory> support
> * solr 5.5(\?) deprecates (but maintains) <mergePolicy> support
> * solr 6.0(\?) removes <mergePolicy> support 
> +work-in-progress git branch:+ [master-solr-8621|https://github.com/apache/lucene-solr/tree/master-solr-8621]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message