lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7013) Move license header before package declaration in all *.java files
Date Thu, 04 Feb 2016 07:23:39 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131860#comment-15131860
] 

Shai Erera commented on LUCENE-7013:
------------------------------------

Thanks [~mikemccand] and [~gerlowskija] for your comments. I've applied both to the script.
I also tweaked it a bit so that it matches more-than-one-repeating-space, since in some of
the files we have trailing whitespace or too many spaces before the Apache URL.

It's interesting to see that we have quite a few files with the old header, so now it's a
chance to fix them too (e.g. {{LazyDocument.java}}).

I will do a dry-run on few modules before I'll actually make any changes.

> Move license header before package declaration in all *.java files
> ------------------------------------------------------------------
>
>                 Key: LUCENE-7013
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7013
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>         Attachments: LUCENE-7013.patch, mvcopyright.py
>
>
> In LUCENE-7012 we committed a change to the IDE templates to place the license header
before the package declaration in new Java files.
> I wrote a simple Python script which moves the header before the package declaration.
To be on the safe side, if a .java file does not already start with the license header or
with {{package org.apache}}, it doesn't modify it and asks for manual intervention.
> It runs quite fast, so I don't mind running and committing one module at a time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message