lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8648) Support selective clearing up of stored async collection API responses
Date Mon, 08 Feb 2016 20:23:40 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137622#comment-15137622
] 

Shai Erera commented on SOLR-8648:
----------------------------------

Thanks [~anshumg], I've got few minor (style) comments:

{{OverseerTaskProcessor}}

* {{if(asyncId != null)}: can you add a space after the 'if'?
* Someplace else in the file: {{if(!runningMap.remove(asyncId))}} - also missing space

{{DistributedMap.remove()}}

* I believe the javadocs won't render well as the \@return tag swallows newlines. You can
either use an {{<ul>}} element, or document it in text instead of the tag.

{{CollectionsHandler}}

* {{public static final String FLUSH = "flush";}} is also defined in CollectionAdminParams.
Can we have just one definition?
* I don't see a deprecation/removal of {{requestId == -1}}. Do you intend to do that separately?
* {{if (requestId != null && flush)}} "Both requestid or flush" should be "Both requestid
*and* flush"
* {{if (req.getParams().getBool(FLUSH, false))}} is redundant since you already set it to
{{flush}} above
* {{zkController.getOverseerFailureMap().remove(requestId);}} that's a mistake? You already
call remove inside the 'if'

{{DeleteStatusTest}}

* {{// Try deleting the same response again}} s/response/requestid/ ?

{{CoreAdminParams}}

* {{public static final String CLEANUP = "cleanup"}} I didn't get where it's used in this
patch?

> Support selective clearing up of stored async collection API responses
> ----------------------------------------------------------------------
>
>                 Key: SOLR-8648
>                 URL: https://issues.apache.org/jira/browse/SOLR-8648
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Anshum Gupta
>            Assignee: Anshum Gupta
>         Attachments: SOLR-8648.patch, SOLR-8648.patch
>
>
> The only way to clear up stored collection API responses right now is by sending in '-1'
as the request id in the REQUESTSTATUS call. It makes a lot of sense to support selective
deletion of stored responses so the ids could be reused.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message