lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mbreslow <>
Subject [GitHub] lucene-solr pull request: SOLR-8639 replace static SimpleDateForma...
Date Thu, 04 Feb 2016 03:06:45 GMT
GitHub user mbreslow opened a pull request:

    SOLR-8639 replace static SimpleDateFormat with threadsafe jodatimeDateFormatter

    Resolve issue SOLR-8639: 
    sinceDateParser and afterFmt are declared as static variables of type SimpleDateFormat
which is not threadsafe. This may cause data corruption and an incorrect value to be returned
by the methods that use them.

You can merge this pull request into a Git repository by running:

    $ git pull SOLR-8639-replace-static-sdf-with-jodatime

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
commit b5832f0e27a399d8d9a24e1fd9a77e876cc1cbe5
Author: Marc Breslow <>
Date:   2016-02-04T03:02:37Z

    Replaced static class variables of type SimpleDateFormat with DateTimeFormatter instances
from joda-time.
    The joda-time types are threadsafe which is appropriate for this usecase. Keeping the
SDF instances could
    cause data corruption or incorrect values to be returned from the methods that use them.

commit ebf7b79ece36a0fca445f99b19931c32bb04b57c
Author: Marc Breslow <>
Date:   2016-02-04T03:05:01Z

    clean up imports


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message