lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-7516) Improve javadocs for JavaBinCodec, ObjectResolver and enforce the single-usage policy
Date Wed, 02 Mar 2016 17:13:18 GMT

     [ https://issues.apache.org/jira/browse/SOLR-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shalin Shekhar Mangar updated SOLR-7516:
----------------------------------------
    Attachment: SOLR-7516.patch

This passes all tests. Ironically, TestJavaBinCodec itself was re-using JavaBinCodec against
its own recommendations :)

I'll commit after the 6.0 branch is cut.

> Improve javadocs for JavaBinCodec, ObjectResolver and enforce the single-usage policy
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-7516
>                 URL: https://issues.apache.org/jira/browse/SOLR-7516
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>            Reporter: Shalin Shekhar Mangar
>            Priority: Minor
>              Labels: difficulty-easy, newdev
>             Fix For: 5.2, master
>
>         Attachments: SOLR-7516.patch, SOLR-7516.patch, SOLR-7516.patch, SOLR-7516.patch
>
>
> The Javadocs of this class can use some improvements. It doesn't adequately describe
the purpose of the ObjectResolver. Also, since it says that this object should be used only
once for marshalling or unmarshalling operation, we should enforce it in code via asserts
and/or exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message