lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Woodward (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-6871) Move SpanQueries out of .spans package
Date Thu, 24 Mar 2016 19:27:25 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alan Woodward updated LUCENE-6871:
----------------------------------
    Attachment: LUCENE-6871.patch

Here's an updated patch that just moves everything out of the .spans package into oal.search.
 I think this is worth doing before 6.0?  It would also allow us to make package-private a
bunch of classes in oal.search that are currently public but marked as internal, just because
they're used by Spans.

Merging SpanTermQuery and TermQuery, etc, can be looked at in follow up issues.

> Move SpanQueries out of .spans package
> --------------------------------------
>
>                 Key: LUCENE-6871
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6871
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 5.4, master
>            Reporter: Alan Woodward
>         Attachments: LUCENE-6871.patch, LUCENE-6871.patch
>
>
> SpanQueries are now essentially the same as a standard query, restricted to a single
field and with an extra scorer type returned by getSpans().  There are a number of existing
queries that fit this contract, including TermQuery and PhraseQuery, and it should be possible
to make them SpanQueries as well without impacting their existing performance.  However, we
can't do this while SpanQuery and its associated Weight and Spans classes are in their own
package.
> I'd like to remove the o.a.l.search.spans package entirely, in a few stages:
> 1) Move SpanQuery, SpanWeight, Spans, SpanCollector and FilterSpans to o.a.l.search
> 2) Remove SpanTermQuery and merge its functionality into TermQuery
> 3) Move SpanNear, SpanNot, SpanOr and SpanMultiTermQueryWrapper to o.a.l.search
> 4) Move the remaining SpanQueries to the queries package
> Then we can look at, eg, making PhraseQuery a SpanQuery, removing SpanMTQWrapper and
making MultiTermQuery a SpanQuery, etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message