lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7053) Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator(); remove natural comparator in favour of Java 8 one
Date Tue, 01 Mar 2016 17:37:18 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174080#comment-15174080
] 

ASF subversion and git services commented on LUCENE-7053:
---------------------------------------------------------

Commit 3c27980c4ae7777716ba74b3a0e2c70b3dd1c1d4 in lucene-solr's branch refs/heads/master
from [~thetaphi]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3c27980 ]

LUCENE-7053: Simplify code to work around Java 8u25 compiler bug


> Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator(); remove natural comparator
in favour of Java 8 one
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7053
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7053
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/other
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: master, 6.0
>
>         Attachments: LUCENE-7053.patch, LUCENE-7053.patch, LUCENE-7053.patch, LUCENE-7053.patch
>
>
> Followup from LUCENE-7052: This removes the legacy, deprecated getUTF8SortedAsUTF16Comparator()
in the BytesRef class. I know originally we added the different comparators to be able to
allow the index term dict to be sorted in different order. This never proved to be useful,
as many Lucene queries rely on the default order. The only codec that used another byte order
internally was the Lucene 3 one (but it used the unicode spaghetti algorithm to reorder its
term enums at runtime).
> This patch also removes the BytesRef-Comparator completely and just implements compareTo.
So all code can rely on natural ordering.
> This patch also cleans up other usages of natural order comparators, e.g. in ArrayUtil,
because Java 8 natively provides a comparator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message