lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7056) Spatial3d/Geo3d should have zero runtime dependencies
Date Wed, 02 Mar 2016 10:54:18 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175425#comment-15175425
] 

Michael McCandless commented on LUCENE-7056:
--------------------------------------------

bq. I'd like to to consider separating these 2 classes out by package.

+1, this seems like a good compromise, and it would match what we have
in 5.x (separate package holds the Lucene classes from the "pure geo3d
math" classes).

bq. instead we just make one thats wired at WGS84, and consider a separate point class that
is "expert" or "custom" that works with other models.

+1 to make WGS84 the "obvious" default, and all other planet models
expert: it's the best earth model spatial3d has.

I also wonder if we can somehow improve the naming ... 3D makes it
seem like you get to index altitude as well, but that's not the case
(you are still indexing and searching points described with 2D
coordinates, e.g. lat/lon).  Rather, it's using math in unprojected
(3D) space to more accurately compute things on the surface of the
idealized (ellipsoid) planet.  Anyway, these are separate issues ...

bq. If you folks make everything that we need package private, we're screwed.

OK, let's leave them public then ... but they may move around a lot in
the future!  They are all already {{@lucene.experimental}}, I
believe.

bq. Part of the thrill I get in contributing to open-source is knowing my code is used so
widely, and hearing kind remarks of its usefulness. Don't you?

Yes!  But we need to stay focused in Lucene: we can't try to be
everything to everyone otherwise we can't achieve the one job we do
have (awesome indexing and searching) which is already hard enough by
itself ;)


> Spatial3d/Geo3d should have zero runtime dependencies
> -----------------------------------------------------
>
>                 Key: LUCENE-7056
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7056
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 6.0
>
>
> This is a proposal for the "spatial3d" module to be purely about the shape/geometry implementations
it has.  In Lucene 5 that's actually all it has.  In Lucene 6 at the moment its ~76 files
have 2 classes that I think should go elsewhere: Geo3DPoint and PointInGeo3DShapeQuery.  Specifically
lucene-spatial-extras (which doesn't quite exist yet so lucene-spatial) would be a suitable
place due to the dependency.   _Eventually_ I see this module migrating elsewhere be it on
its own or a part of something else more spatial-ish.  Even if that never comes to pass, non-Lucene
users who want to use this module for it's geometry annoyingly have to exclude the Lucene
dependencies that are there because this module also contains these two classes.
> In a comment I'll suggest some specifics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message