lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7059) Verify that 1D point values are visited in order
Date Wed, 02 Mar 2016 22:19:18 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176595#comment-15176595
] 

ASF subversion and git services commented on LUCENE-7059:
---------------------------------------------------------

Commit 25cc48bbb8cc11c2f7a2c9da30d675c9ae5926ca in lucene-solr's branch refs/heads/branch_6x
from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=25cc48b ]

LUCENE-7059: remove MultiPointValues


> Verify that 1D point values are visited in order
> ------------------------------------------------
>
>                 Key: LUCENE-7059
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7059
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Blocker
>             Fix For: master, 6.0
>
>         Attachments: LUCENE-7059.patch
>
>
> The new PointInSetQuery (LUCENE-7048) hit a tricky test failure
> (https://builds.apache.org/job/Lucene-Solr-Tests-trunk-Java8/871/)
> where point values were sometimes not visited in order like it
> expected.
> I pushed a hack to fix the query, but I think we should do a better
> fix, here, making the "values in order in the 1D case" part of the
> API, fixing CheckIndex, AssertingPointFormat to verify this, and
> removing the buggy MultiPointValues.
> I also found a possibly serious bug in BKDWriter, where it was doing
> {{writeInt/writeLong}} to its offline files, but then reading with
> {{readVInt/readVLong}}!  It's hard to provoke, though: it only strikes
> in the tie-break case (same values across docs), and even then only if
> the {{IntroSorter}} does a non-stable sort.  I made a failing test
> case and fixed that bug, and also removed the unnecessary ord tie
> breaking from BKDWriter's comparator.
> Finally, I saw {{BKDWriter}} was failing to pass on its
> {{maxMBSortInHeap}} down to {{OfflineSorter}}, and fixed that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message