lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (LUCENE-7059) Verify that 1D point values are visited in order
Date Thu, 03 Mar 2016 15:23:18 GMT


ASF subversion and git services commented on LUCENE-7059:

Commit b38c2d698a70e56b2be7006f30f628452c85cfdc in lucene-solr's branch refs/heads/branch_6_0
from Mike McCandless
[;h=b38c2d6 ]

LUCENE-7059: remove MultiPointValues
(cherry picked from commit 25cc48b)

> Verify that 1D point values are visited in order
> ------------------------------------------------
>                 Key: LUCENE-7059
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Blocker
>             Fix For: master, 6.0
>         Attachments: LUCENE-7059.patch
> The new PointInSetQuery (LUCENE-7048) hit a tricky test failure
> (
> where point values were sometimes not visited in order like it
> expected.
> I pushed a hack to fix the query, but I think we should do a better
> fix, here, making the "values in order in the 1D case" part of the
> API, fixing CheckIndex, AssertingPointFormat to verify this, and
> removing the buggy MultiPointValues.
> I also found a possibly serious bug in BKDWriter, where it was doing
> {{writeInt/writeLong}} to its offline files, but then reading with
> {{readVInt/readVLong}}!  It's hard to provoke, though: it only strikes
> in the tie-break case (same values across docs), and even then only if
> the {{IntroSorter}} does a non-stable sort.  I made a failing test
> case and fixed that bug, and also removed the unnecessary ord tie
> breaking from BKDWriter's comparator.
> Finally, I saw {{BKDWriter}} was failing to pass on its
> {{maxMBSortInHeap}} down to {{OfflineSorter}}, and fixed that.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message