lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7063) NumericUtils vs LegacyNumericUtils chaos with 6.0
Date Thu, 03 Mar 2016 03:59:18 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177116#comment-15177116
] 

Robert Muir commented on LUCENE-7063:
-------------------------------------

As far as NumericUtils.intToBytes -> NumericUtils.intToSortableBytes, i think its super
trappy to have a method with no javadocs called NumericUtils.intToBytes that is doing the
sign-bit flipping. 

AFAIK LegacyNumericUtils always named this 'toPrefixCoded' so we never had this confusion
before.

> NumericUtils vs LegacyNumericUtils chaos with 6.0
> -------------------------------------------------
>
>                 Key: LUCENE-7063
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7063
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-7063.patch
>
>
> Old prefix-coded terms helper functions are still available in LegacyNumericUtils, but
its confusing when upgrading because NumericUtils and LegacyNumericUtils have overlaps in
the APIs.
> One issue is they share some exact methods that are completely unrelated to this encoding
(e.g. floatToSortableInt). The method is just duplication and worst, most lucene code is still
calling it from LegacyNumericUtils, even stuff like faceting code using it with docvalues.
> Another issue is the new NumericUtils methods (which use full byte range) have vague
names, no javadocs, expose helper methods as public unnecessarily, and cause general confusion.
> I don't think NumericUtils and LegacyNumericUtils should overlap. LegacyNumericUtils
should only contain legacy stuff!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message